-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: remove active class on first item in nav, when scrolled back up #29
Comments
This is a very useful and lightweight scrollspy script, so thanks for your work. I think it would be perfect if not for this issue, which appears as a bug to the end user. |
@jboiss @remcokalf Excuse me! I'm sorry for late reply. Could you, please give me a capture image for this issue? |
This thread has been locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi, was this issue fixed? Or just closed? I don't see any commits related to it? I don't understand why you asked for a screen capture. Was the description not clear? I can provide a capture of the issue next week. |
I am reopening this issue as the previous fix has led to a more critical bug (#59). We need to explore alternative solutions. The problem persists in version 2.5.1. Screen.Recording.2024-09-18.at.23.30.56.mov |
Currently, when scrolling down, active classes are added and removed. Then scrolling back up, the last item (first in the nav) keeps its active class, even if the correponding section is way past it.
This looks confusing, especially in a page where the content + nav are a bit lower, e.g. below a large hero section.
When you scroll back up, and the section is way low, the first item still keeps its active class.
The text was updated successfully, but these errors were encountered: