Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: remove active class on first item in nav, when scrolled back up #29

Open
remcokalf opened this issue Dec 9, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@remcokalf
Copy link

Currently, when scrolling down, active classes are added and removed. Then scrolling back up, the last item (first in the nav) keeps its active class, even if the correponding section is way past it.

This looks confusing, especially in a page where the content + nav are a bit lower, e.g. below a large hero section.
When you scroll back up, and the section is way low, the first item still keeps its active class.

@jboiss
Copy link

jboiss commented Apr 11, 2022

This is a very useful and lightweight scrollspy script, so thanks for your work. I think it would be perfect if not for this issue, which appears as a bug to the end user.

@kimyvgy
Copy link
Owner

kimyvgy commented Oct 3, 2022

@jboiss @remcokalf Excuse me! I'm sorry for late reply. Could you, please give me a capture image for this issue?

@kimyvgy
Copy link
Owner

kimyvgy commented Oct 10, 2022

This thread has been locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@kimyvgy kimyvgy closed this as completed Oct 10, 2022
@remcokalf
Copy link
Author

Hi, was this issue fixed? Or just closed? I don't see any commits related to it? I don't understand why you asked for a screen capture. Was the description not clear? I can provide a capture of the issue next week.

@kimyvgy
Copy link
Owner

kimyvgy commented Sep 18, 2024

I am reopening this issue as the previous fix has led to a more critical bug (#59). We need to explore alternative solutions. The problem persists in version 2.5.1.

Screen.Recording.2024-09-18.at.23.30.56.mov

@kimyvgy kimyvgy added the bug Something isn't working label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants