Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream decoding is insufficiently lazy #4

Open
vmchale opened this issue Apr 17, 2020 · 3 comments · May be fixed by #5
Open

Stream decoding is insufficiently lazy #4

vmchale opened this issue Apr 17, 2020 · 3 comments · May be fixed by #5

Comments

@vmchale
Copy link

vmchale commented Apr 17, 2020

Right now, it seems impossible to use snappy frames lazily to stream-decode a file (this came up downstream here).

Thanks!
@kim
Copy link
Owner

kim commented Apr 18, 2020

Ya, seems like past self hadn’t figured out streaming with just Data.Binary — I did use the Binary instance directly with conduit. If that’s not an option for you, I think you could also use runGetOrFail recursively. It returns the unconsumed input as a lazy bytestring.

@kim
Copy link
Owner

kim commented May 4, 2020 •
edited
Loading

Interestingly, I can’t seem to build the snappy package anymore, even with bos/snappy#6. Are you using a fork? Otherwise, it might be time to either deprecate this package, or maintain the snappy bindings here.

@vmchale
Copy link
Author

vmchale commented May 5, 2020

It's broken on mac :( definitely not on Linux but snappy itself has an open PR :)

kim added a commit that referenced this issue Jun 5, 2020
@kim
Make decoding lazier
8ab84bd 
Fixes #4
@kim kim linked a pull request Jun 5, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make decoding lazier kim/snappy-framing
2 participants
@kim @vmchale