Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kll compiler doesn't warn when missing a semicolon #31

Open
dnppp opened this issue Jan 23, 2019 · 1 comment
Open

kll compiler doesn't warn when missing a semicolon #31

dnppp opened this issue Jan 23, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@dnppp
Copy link

dnppp commented Jan 23, 2019

last commit when getting this issue: 6ea6b7e (kll), e94a6562 (controller)

When using the default kira keymaps (release.1.kll), replacing the 2 layer combinations at the top by:

### Custom key mappings
 
U"ESC" : U"CAPSLOCK"
U"CAPSLOCK" : U"ESC"
 
 
### Layer Combinations ###
 
U"RCtrl" + U"F1" : Layer[1];
U"RCtrl" + U"F2" : Layer[2];
U"RCtrl" + U"F3" : Layer[3];
U"RCtrl" + U"F4" : Layer[4];

(note the missing semicolons before the layer combinations comment)

The above kll will compile file, the compiler will not output any warning, but ESC and CAPSLOCK will not be interchanged, and layer switching (RCTRL+F1) will not work.

@dnppp
Copy link
Author

dnppp commented Jan 23, 2019

(firmware compiled with docker)

@haata haata self-assigned this Feb 19, 2019
@haata haata added the bug label Feb 19, 2019
@haata haata added this to the v0.5.x milestone Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants