Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental update updates padding to late for first node #72

Open
soerendomroes opened this issue Oct 12, 2020 · 1 comment
Open

Incremental update updates padding to late for first node #72

soerendomroes opened this issue Oct 12, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@soerendomroes
Copy link
Member

Given the following graph:

algorithm: rectpacking
spacing.nodeNode: 0
onlyFirstIteration: true
elk.padding: "[top=0.0,left=0.0,bottom=0.0,right=0.0]"

node n1 {
  layout[size: 20, 20]
}
node n2 {
  layout[size: 20, 20]
}
node n3 {
  layout[size: 20, 20]
}
node n4 {
  layout[size: 20, 20]
}
node n5 {
  layout[size: 20, 20]
}
node n6 {
  layout[size: 20, 20]
}

Screenshot from 2020-10-12 14-38-04
If one changes the left padding to 10.0 and then back to 0. The node n1 is still placed at padding 10.
Screenshot from 2020-10-12 14-39-20

@soerendomroes soerendomroes added the bug Something isn't working label Oct 12, 2020
@NiklasRentzCAU
Copy link
Member

This does not seem to be an issue with the IncrementalUpdateStrategy, as following the same steps in the Sprotty viewer using the same strategy does not have this problem. The KGraph coming out of the incremental update also does not seem to show any difference between the first and the other nodes, so I would guess the issue is somewhere later in the toolchain, maybe when updating the KNodeNode representation or somewhere in Piccolo2D itself. As I don't know how any of that code really works, I don't think I can help you here right now without having a deep dive into the piccolo rendering.

@NiklasRentzCAU NiklasRentzCAU removed their assignment Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants