-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#44] Branches Comparison #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now! @lampajr
@Ginxo apart from the look and feel which is minimal and should be improved, the rest seems to work (both showing the information and gathering it from github). I'll try a POC on a custom repository pointing to this branch and I'll post here some screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 2 technical changes proposal
packages/webpage/src/components/branches/BranchesDiffsByProject.tsx
Outdated
Show resolved
Hide resolved
packages/webpage/src/components/branches/ProjectBranchesDiffsByBranch.tsx
Outdated
Show resolved
Hide resolved
packages/webpage/src/components/branches/BranchesDiffsByProject.tsx
Outdated
Show resolved
Hide resolved
@Ginxo I fixed the webpage in according to our last call, it can definitely be improved further but the result now is much better then the previous one. Instead of adding a gray background I preferred to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I LOVE IT!!! mark it as ready for review whenever you feel comfortable with it
I'll fix the problem of reducing the generated data size and this #45 (comment) point and then I think everything is done |
@Ginxo I think we have to think more about reducing the generated data size.
Maybe considering to keep only the data that we really need. |
Removing some useless information from branches comparison (i.e., keeping only
We can re-include all data for a future persepctive while solving issue #46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just few proposals
packages/webpage/src/components/current-status/ContainerHeader.tsx
Outdated
Show resolved
Hide resolved
packages/webpage/src/components/current-status/ContainerHeader.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Enrique Mingorance Cano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any way new issue open for improving few pending parts
#47
Thank you for submitting this pull request
fixes #44
Improvements