Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octokit initialization using personal userAgent #38

Open
lampajr opened this issue Aug 18, 2022 · 2 comments
Open

Octokit initialization using personal userAgent #38

lampajr opened this issue Aug 18, 2022 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lampajr
Copy link
Member

lampajr commented Aug 18, 2022

From the code I see that the Octokit constructor is invoked using personal userAgent.

function createOctokitInstance(token) {
  return token
    ? new Octokit({
        auth: `token ${token}`,
        userAgent: "ginxo/chain-status"
      })
    : new Octokit({
        userAgent: "ginxo/chain-status"
      });
}

I suggest to add this as cli/gha argument since as the Octokit doc recommend we should set it to the application using it.

@Ginxo
Copy link
Collaborator

Ginxo commented Aug 18, 2022

Thanks for opening this @lampajr
I agree, just one comment, I suggest to use optional parameter otherwise we will use kiegroup/chain-status, wdyt?

@Ginxo Ginxo added the good first issue Good for newcomers label Aug 18, 2022
@lampajr
Copy link
Member Author

lampajr commented Aug 18, 2022

I agree on keeping the kiegroup/chain-status default.

@Ginxo Ginxo added the bug Something isn't working label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants