Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status tags contains an empty string #376

Open
dankolbman opened this issue Jun 16, 2018 · 2 comments
Open

Status tags contains an empty string #376

dankolbman opened this issue Jun 16, 2018 · 2 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dankolbman
Copy link
Contributor

dankolbman commented Jun 16, 2018

The status endpoint currently returns an additional empty string as a tag. This should be removed.

 curl  -s 'https://kf-api-dataservice-qa.kids-first.io/status'
{
  "_status": {
    "branch": "HEAD",
    "code": 200,
    "commit": "212a49c",
    "message": "Welcome to the Kids First Dataservice API",
    "tags": [
      "1.1.4",
      ""
    ],
    "version": "1.1.4"
  }
}
@dankolbman dankolbman added bug Something isn't working help wanted Extra attention is needed labels Jun 16, 2018
@liberaliscomputing
Copy link
Contributor

To be more specific, the status endpoint in QA returns tags as an empty array:

{
    "_status": {
        "branch": "HEAD",
        "code": 200,
        "commit": "dfc53b8",
        "message": "Welcome to the Kids First Dataservice API",
        "tags": [],
        "version": "1.1.4"
    }
}

whereas PRD returns an additional empty string as a tag as pointed out:

{
    "_status": {
        "branch": "HEAD",
        "code": 200,
        "commit": "212a49c",
        "message": "Welcome to the Kids First Dataservice API",
        "tags": [
            "1.1.4",
            ""
        ],
        "version": "1.1.4"
    }
}

@liberaliscomputing liberaliscomputing self-assigned this Jun 17, 2018
@dankolbman
Copy link
Contributor Author

It makes sense that qa and dev do not have tags, as those commits have no tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants