Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve dApp connection dialog #176

Open
d13co opened this issue Feb 16, 2024 · 1 comment
Open

[Feature]: Improve dApp connection dialog #176

d13co opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
✨ feature New feature or request

Comments

@d13co
Copy link
Contributor

d13co commented Feb 16, 2024

What is your idea or feature suggestion?

In the dApp connection window:

  • "Allow" button should be disabled until an account is selected
  • Consider adding a "default account" option somewhere in the UI which is pre-selected.
    • Alternatively this could default to the last used account? Clumsier imo.
    • Ideally there would be a setting to define this behavior but that juice may not be worth the squeeze at this point

The wallet selection prompt could also be bolder. Especially with the Allow button active (and no error message/popup), I thought it glitched out until I read closer.

Finally, the react-app icon + label should be replaced with kibisis branding

1708114502

Benefits

Improves UX

Where can we find information about this?

No response

Are you willing to provide a PR to address this?

No

@d13co d13co added the ✨ feature New feature or request label Feb 16, 2024
@d13co d13co changed the title [Feature]: [Feature]: Improve dApp connection dialog Feb 16, 2024
@kieranroneill
Copy link
Member

Thank you for this, it definitely has been in need of a rework.

I have updated this screen in recent updates and added a few of the changes that you suggested:

  • The first account is selected by default.
  • A select all checkbox has been added to allow all accounts to be selected.

I am still in the progress of making a default account. I want a primary type account as I move towards allowing users to setup a "profile" using an NFT. The default account will be key to this, but I want users to also be able to switch this primary account too.

As for disabling buttons, I try to avoid that as much as possible. It is considered bad UX and is a big no-no for accessibility. Around the app I have tried to subscribe to the UX where the user can press the CTA button until their heart is content, but also inform them where they need to complete the required data to progress futher, rather than disabling and letting the user figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants