Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only jar archiveType is valid #31

Open
benjamin-cartereau opened this issue Oct 15, 2019 · 3 comments · May be fixed by #33
Open

Only jar archiveType is valid #31

benjamin-cartereau opened this issue Oct 15, 2019 · 3 comments · May be fixed by #33

Comments

@benjamin-cartereau
Copy link

benjamin-cartereau commented Oct 15, 2019 •
edited
Loading

Whatever archiveType is set (zip, jar, tar.gz...) we get a jar archive when using configuration goal (mojo).
It looks like archiveType is only used to set file extension name but not the appropriate underlying archiver.
My use case requires a ".tar.gz". Eventually I get a file with the right extension et it is not a "tar.gz" archive but a jar one.
When looking at the code, I can see that only the JarArchiver (https://github.com/khmarbaise/multienv-maven-plugin/blob/multienv-maven-plugin-0.3.1/src/main/java/com/soebes/maven/plugins/multienv/ConfigurationMojo.java#L36) is used.
benjamin-cartereau added a commit to benjamin-cartereau/multienv-maven-plugin that referenced this issue Oct 15, 2019
@benjamin-cartereau
Fixed khmarbaise#31 - Only jar archiveType is valid
1727d19
@benjamin-cartereau benjamin-cartereau linked a pull request Oct 15, 2019 that will close this issue
Open
@khmarbaise
Copy link
Owner

Can you please rebase your branch with current master to get a working build and to get a feedback of your PR...

benjamin-cartereau added a commit to benjamin-cartereau/multienv-maven-plugin that referenced this issue Oct 21, 2019
@benjamin-cartereau
Fixed khmarbaise#31 - Only jar archiveType is valid
0720c04
@benjamin-cartereau
Copy link
Author

I hope it is better now

@vinaykumarmalathi
Copy link

tar archiveType fix is still not available in main ibrary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #31 - Only jar archiveType is valid benjamin-cartereau/multienv-maven-plugin
3 participants
@khmarbaise @benjamin-cartereau @vinaykumarmalathi