Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_onlineTA makes very specific assumptions on submission structure #63

Open
madsobitsoe opened this issue Nov 28, 2022 · 0 comments
Open

Comments

@madsobitsoe
Copy link
Contributor

The code currently expects a submission to

  • contain a file matching the regex README* in the root directory
    And OnlineTA to:
  • expect a file named code.zip

It also unpacks the submitted zip-file and re-zips it before sending it to online_ta as code.zip.

These assumptions are iirc. from PoP2021. I believe they should be removed.

The good thing about unzipping and rezipping is that we avoid submitting "junk" by cleaning up the students handins first.
The con of that, is that we hide the students' errors from them.
It's a choice between "making stuff work" and reporting errors.

I suggest we either add another function or clean up the one we already have.
The filename of the rezipped file should be the same as the submitted zip-file. (Or just use the submitted zip-file, although that will cause a lot fewer PoP-submissions to go through onlineTA successfully).

def run_onlineTA(base, handin, url):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant