Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable the event metrics for users by default #1051

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Nov 21, 2024

Fixes #1050 partially.

@kami619
Copy link
Contributor Author

kami619 commented Nov 22, 2024

Once we add these flags in the deployment, we are able to enable the user event metrics in the Keycloak nightly runs.

@kami619 kami619 marked this pull request as ready for review November 22, 2024 17:20
@ahus1
Copy link
Contributor

ahus1 commented Nov 25, 2024

Once we add these flags in the deployment, we are able to enable the user event metrics in the Keycloak nightly runs.

@kami619 - reading your comment, it seems to differ from the changes in this PR: Once this PR is merged, the user event metrics are enabled.

Did you run a smoke test to see any performance changes before or after, or do you plan to merge it straight away and then try in out in our nightly run?

BTW: please go ahead and merge if you think those comments are already addressed.

@kami619 kami619 merged commit 6e5d4c6 into keycloak:main Nov 25, 2024
3 checks passed
@kami619
Copy link
Contributor Author

kami619 commented Nov 25, 2024

@ahus1 thanks Alexander, we agreed to merge this and utilize the nightly run to observe the performance overhead, if any. I will work on the docs and the prototype dashboard in the meantime and raise another PR.

@kami619 kami619 deleted the is-1050-event-metrics-user-enabled branch November 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable event-metrics-user-enabled in Keycloak benchmark deployments
2 participants