Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Jay's Proposal #5

Open
purple4reina opened this issue Aug 18, 2015 · 0 comments
Open

Feedback on Jay's Proposal #5

purple4reina opened this issue Aug 18, 2015 · 0 comments
Assignees

Comments

@purple4reina
Copy link
Collaborator

Jay, great work on your proposal. I think this will be a great project for you. It is small and contained, yet gives enough complexity for you to show off your hidden talents. It is also highly functional.

What I am liking:

  • That you have a clear idea of what you want your pages to look like. It would be amazing if there was a way to include images here...
  • Your project is very functional and usable. I love it! A lot of people will find this useful.

Here are some thoughts for you as you work on your second draft:

  • You have several grammatical errors which make the document hard to read. This course is not an English course, but in this case, I am finding it hard to understand what you are talking about. One example: "Create event listeners and handlers for accompany given character fields."
  • In the description section you say " to an email of the user's choosing" but later you say that the email system "will not be seen by common users." Which is it? If you are wanting this to be an admin only feature, change the word "user" in the description section to "admin."
  • How will the database be storing these "time stamps"? How will you know if the stamp is a clock-in or a clock-out? This will be an important decision as you design your models, so it will be great to get started thinking it through.
  • Be sure to consider when the email will be sent. Is it once a month? Once a day? Could the admin decide?
  • This is a run-on sentence and I have no idea what you are talking about: "Give authorization automatically without secondary approval through admin with use of randomly generated code given by admin prior to logging in"
  • You say "Information format: Find way to format information received from application, to be ready for email." What do you mean by application? What do you mean by information? Clearer language here will help me and you understand your ideas better.
  • Django has emailing functionality. It's pretty awesome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants