Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding catwoman_tr to model transit limb-asymmetries #702

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Conversation

taylorbell57
Copy link
Collaborator

This PR makes progress on resolving #314 by adding support for the catwoman astrophysical model which can be used to model transit limb-asymmetry. catwoman is heavily based off of batman, so adding support for the model ended up being quite easy. No need to delay v1.0 for this PR, but just thought I'd publish it now since I'd got it working already

@taylorbell57 taylorbell57 added enhancement New feature or request LC Fit labels Sep 21, 2024
@taylorbell57
Copy link
Collaborator Author

Note that the pytest error is caused by an installation issue with catwoman which will be resolved by a PR that I've submitted to their repo

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 57.57%. Comparing base (9de59a3) to head (05aa571).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
.../eureka/S5_lightcurve_fitting/models/AstroModel.py 26.31% 14 Missing ⚠️
...reka/S5_lightcurve_fitting/models/CatwomanModel.py 46.15% 7 Missing ⚠️
src/eureka/S5_lightcurve_fitting/s5_fit.py 50.00% 2 Missing ⚠️
src/eureka/lib/util.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   57.62%   57.57%   -0.05%     
==========================================
  Files         112      113       +1     
  Lines       14082    14123      +41     
==========================================
+ Hits         8115     8132      +17     
- Misses       5967     5991      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taylorbell57
Copy link
Collaborator Author

@kevin218, a reminder that this PR is ready for you to review when you get the chance

docs/source/ecf.rst Outdated Show resolved Hide resolved
docs/source/ecf.rst Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
@taylorbell57 taylorbell57 merged commit 7483bc0 into main Nov 7, 2024
4 of 6 checks passed
@taylorbell57 taylorbell57 deleted the catwoman branch November 7, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LC Fit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants