-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding catwoman_tr to model transit limb-asymmetries #702
Conversation
Note that the pytest error is caused by an installation issue with catwoman which will be resolved by a PR that I've submitted to their repo |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 57.62% 57.57% -0.05%
==========================================
Files 112 113 +1
Lines 14082 14123 +41
==========================================
+ Hits 8115 8132 +17
- Misses 5967 5991 +24 ☔ View full report in Codecov by Sentry. |
@kevin218, a reminder that this PR is ready for you to review when you get the chance |
This PR makes progress on resolving #314 by adding support for the catwoman astrophysical model which can be used to model transit limb-asymmetry. catwoman is heavily based off of batman, so adding support for the model ended up being quite easy. No need to delay v1.0 for this PR, but just thought I'd publish it now since I'd got it working already