-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Stage 3 NIRCam row-by-row background subtraction is broken #719
Comments
Can you post your Stage 2 and Stage 3 ECFs? Also, what dataset are you trying to analyze? You may have specified some earlier step incorrectly, as every pixel in the image is marked as bad, so there's no actual data being analyzed after those steps. |
Data Specifications (needed to input the MAST JWST Search):
|
Does Stage 3 work when you don't run row-by-row background subtraction? |
Are you running F322W2 and F444W observations simultaneously? You can only do one filter at a time, and based on your previous message it seems to me that you're working on both filters at the same time. You'll need to put the F322W2 and F444W files in separate folders. Also make sure that you're only working on the spectroscopy files and not also the simultaneously collected photometry files |
@mithun1996-png, can you confirm whether you're still dealing with this issue? |
this issue is still happen ,but in stage 3 ecf file when i fix row by row background subtraction is true then this issue actually come up. but if i set row by row background subtraction then their is no issue like that . so can you give a suggestion what can do ,what is the reason for that issue . |
@mithun1996-png, I looked on MAST and there should only be 11 F444W files and 14 F322W2 files; because your log statements up above state |
we get same error when working on only one data set at a time , i am working using F322W filter
Error outcome working with F322W data
|
Alright, I just tested Stage 3's NIRCam row-by-row background subtraction, and I can confirm that there does indeed appear to be some bug that results in all pixels becoming masked. While we work to sort this out, I recommend you stick with column-by-column background subtraction only and set On an unrelated note, I saw that you have accidentally set |
in stage 3 i set Row_by_Row background subtraction set it to false ,its working .and i got white light curve after stage 4 . and then i proceed stage 5 for best fit light curve .but fitting not realistic ,is i doing any mistake if i did please some suggestion . |
hello sir , according to paper correct the 1/f noise correction in each individual pixel in a segment using a 10 sigma threshold , but in ecf file there is no parameter for this ,can you give proper template for this noise correction
|
I'm not sure what you mean by "fitting not realistic". I very strongly recommend you first try your very best to troubleshoot any issues with fitting yourself since these are almost always user error and not caused by a bug with
I think what you're saying is that 1/f noise correction was applied at the group-level (where 1/f correction is more effective); this group-level work would be part of Stage 1 instead of Stage 3. Since the row-by-row background subtraction code is shared between Stages 1 and 3, I assume that Stage 1 row-by-row background subtraction will also fail in the same way at present. Once we get that code working again, there are similar settings in Stage 1 (e.g. bg-row-by-row) as in Stage 3. As for the 10 sigma threshold you mentioned, I'd assume that would be |
Instrument
NIRCam (Stages 1-3)
What happened?
as i am using NIRCam data , so row by row background subtraction is very important , so when i set rorw _by_ror_bg to True , then this type of error is here .
Error traceback output
What operating system are you using?
linux
What version of Python are you running?
python3.10.14
What Python packages do you have installed?
Code of Conduct
The text was updated successfully, but these errors were encountered: