Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffersize support #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add buffersize support #91

wants to merge 4 commits into from

Conversation

6ixfalls
Copy link

@6ixfalls 6ixfalls commented Oct 7, 2021

Assuming that you'd want a parameter passed into every function, optional, stating the buffer size.
Fixes #72.

@kessler
Copy link
Owner

kessler commented Oct 10, 2021

@6ixfalls thank you for your contribution.

we're having an internal debate here, if passing this parameter to every function is the correct way to implement...
to me it feels like it's an environment thing.

Did you consider it and decided against it or?

@6ixfalls
Copy link
Author

6ixfalls commented Oct 10, 2021

After I finished, I kinda thought over and realized that too, though since I had it done already I just made a PR. I could make it a global variable that you set either through a function or variable, which I think would be optimal?

@kessler
Copy link
Owner

kessler commented Oct 10, 2021

since I made the mistake many years ago not to export an instance of regedit, but rather have all the functions exported directly we are foced to use a "static" variable, in much the same way we implemented setExternalVBSLocation. @M1cr0M1nd will take care of it, I'll leave this PR open until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify max buffer of execFile
2 participants