kernelci.api.models: fix pydantic warnings for url fields
#2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the below pydantic v2 warnings: ``` Expected `url` but got `str` with value - serialized value may not be as expected ``` This is due to fields such as `artifacts` and `revision.url` expect pydantic `Url` type and afterwards convert the values to `str` to store it in mongo DB and for json response. Change field types to `str` and use `TypeAdapter` to validate `Url` values before validating them as strings. Discussion thread for the issue: pydantic/pydantic#6395 Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
fix-pydantic-warnings-for-url
branch
from
f052615
to
f56ed9d
Compare
pawiecz
approved these changes
Nov 27, 2024
| @@ -117,7 +120,8 @@ class Revision(BaseModel): | |||
| tree: str = Field( | |||
| description="git tree of the revision" | |||
| ) | |||
| url: Annotated[AnyUrl | FileUrl, AfterValidator(str)] = Field( | |||
| url: Annotated[str, BeforeValidator( | |||
| lambda value: str(any_url_adapter.validate_python(value)))] = Field( | |||
There was a problem hiding this comment.
Support for FileURLs without host set is dropped here but I don't think any kind of currently supported Storage types allowed them anyway
There was a problem hiding this comment.
AnyUrl allows FileUrl as well. That's why dropped it from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to kernelci/kernelci-api#560
Fix the below pydantic v2 warnings:
This is due to fields such as
artifactsandrevision.urlexpect pydanticUrltype and afterwards convert the values tostrto store it in mongo DB and for json response. Change field types tostrand useTypeAdapterto validateUrlvalues before validating them as strings.Discussion thread for the issue:
pydantic/pydantic#6395