Feat: HD path filter and patches #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarceloRobert
force-pushed
the
feat/full-path-filter
branch
from
a117a93
to
9370382
Compare
MarceloRobert
commented
Nov 26, 2024
MarceloRobert
force-pushed
the
feat/full-path-filter
branch
from
9370382
to
9522223
Compare
WilsonNet
reviewed
Nov 26, 2024
Comment on lines
261
to
263
| // TODO: there should be a filtering for the frontend before the backend | ||
| // that frontend filtering should consider the individual tests inside each test batch (the data from individualTestsTables), | ||
| // not only the rows of the external table (same for BootsTable) |
There was a problem hiding this comment.
We are not using this approach anymore, we will just preserve the data, add a spinner until the fresh data is retrieved
WilsonNet
reviewed
Nov 26, 2024
Comment on lines
+269
to
+268
| if (updatePathFilter === undefined) { | ||
| table.setGlobalFilter(String(e.target.value)); | ||
| } |
There was a problem hiding this comment.
do we need to set the global filter? since the filter is being added in the backend
There was a problem hiding this comment.
In this case it is being used for tables such as within the buildDetails page, which doesn't have backend filtering for the page so the frontend filtering is being used
WilsonNet
approved these changes
Nov 26, 2024
Comment on lines
336
to
337
| {/* TODO: remove this hidden div, this is just to force memoization reset when sorting changes (all tables) */} | ||
| <div className="hidden">{sorting.toString()}</div> |
There was a problem hiding this comment.
Make TableHead explicitly dependent on sorting
lfjnascimento
approved these changes
Nov 27, 2024
Comment on lines
343
to
339
| : // the header must change the icon when sorting changes, but just the column dependency won't trigger the rerender, so we pass an unused sorting prop here to force the useMemo dependency | ||
| flexRender(header.column.columnDef.header, { |
There was a problem hiding this comment.
break this comments in multiple lines
MarceloRobert
force-pushed
the
feat/full-path-filter
branch
from
eea66d0
to
b079e03
Compare
MarceloRobert
force-pushed
the
feat/full-path-filter
branch
from
b079e03
to
d428e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors the sorting exhaustive-deps useMemo dependency just so eslint can complain if a useMemo dependency is missing
How to test
Go to a tree details page with boot and/or test data, scroll down and use the searchbox alongside the path column. Check the filtering of the table and the commit history graph. Compare this with the previous version currently on staging.
Also go to a hardware details page with boot and/or test data and see the same behavior as in tree details (except for the commit history graph, which isn't implemented yet).
Closes #578 and #582