Feat: add path filter to tree details #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarceloRobert
force-pushed
the
feat/tests-path-filter
branch
from
fab30aa
to
fc351cc
Compare
MarceloRobert
changed the title
MarceloRobert
force-pushed
the
feat/tests-path-filter
branch
2 times, most recently
from
ecf638f
to
36a1b8d
Compare
|
You can add a shadow to separate the filter list from the page content.
|
|
The content of the input should be cleaned after the filters are removed
|
MarceloRobert
force-pushed
the
feat/tests-path-filter
branch
2 times, most recently
from
94f405c
to
5491b09
Compare
|
Go to this link and try filter by path. Remove the filter and try to filter by the same path again give this result
|
|
This behavior persist when use the filter data in the cache |
| {header.id === 'path_group' ? ( | ||
| <div className="flex items-center"> | ||
| {headerComponent} | ||
| <DebounceInput |
There was a problem hiding this comment.
Review about this comment
WilsonNet
reviewed
Nov 22, 2024
| {tabsTrigger} | ||
| </TabsList> | ||
| <div className="border-t border-darkGray py-6">{filterListElement}</div> | ||
| <div className="sticky top-16 z-[5] rounded-md bg-lightGray pb-6 pt-12"> |
There was a problem hiding this comment.
try swapping rounded-md with drop-shadow
There was a problem hiding this comment.
drop-shadow gets a bit weird when nothing else in the page has shadows, but we might try something else another time
WilsonNet
approved these changes
Nov 22, 2024
MarceloRobert
force-pushed
the
feat/tests-path-filter
branch
from
5491b09
to
ee7bbbd
Compare
MarceloRobert
force-pushed
the
feat/tests-path-filter
branch
from
ee7bbbd
to
f6c0599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Go to tests or boots tab in any treeDetails page with boots or tests data,
Scroll down to see the sticky tab selection and filter listing,
Type something in the searchbox alongside the path column,
After a certain delay, the whole page will be filtered by passing a new diffFilter,
Check the filter listing and the diffFilter search param,
The returned data should be filtered by path, including individual tests under the external tests table.
Closes #524