New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`make port-forward-argocd` fails due to missing `ARGO_NAMESPACE` constant #11

Open

agardnerIT opened this issue May 9, 2023 · 0 comments

Labels

bug

agardnerIT commented May 9, 2023 •

edited

Loading

Makefile in the root doesn't have the ARGO_NAMESPACE constant defined and so make port-forward-argocd fails.

Unless I'm missing a reason not to do this, the fix is simple:

# renovate: datasource=github-tags depName=jaegertracing/jaeger-operator
JAEGER_VERSION ?= v1.42.0
TOOLKIT_NAMESPACE ?= keptn-lifecycle-toolkit-system
PODTATO_NAMESPACE ?= podtato-kubectl
GRAFANA_PORT_FORWARD ?= 3000
....

should be modified to:

# renovate: datasource=github-tags depName=jaegertracing/jaeger-operator
JAEGER_VERSION ?= v1.42.0
TOOLKIT_NAMESPACE ?= keptn-lifecycle-toolkit-system
PODTATO_NAMESPACE ?= podtato-kubectl
GRAFANA_PORT_FORWARD ?= 3000
ARGO_NAMESPACE ?= argocd
....

The text was updated successfully, but these errors were encountered:

agardnerIT added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment