This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
fix: Add output of failed events to logs #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we also implement a basic unit test for |
Signed-off-by: Christian Kreuzberger <[email protected]>
Signed-off-by: Christian Kreuzberger <[email protected]>
Signed-off-by: Christian Kreuzberger <[email protected]>
christian-kreuzberger-dtx
force-pushed
the
patch/job-events
branch
from
4f41b1e to
4623907
Compare
|
Added two unit tests and rebased |
|
The following Docker Images have been built:
|
Raffy23
reviewed
May 17, 2022
Raffy23
approved these changes
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: Thanks to the code provided by @Raffy23 in PR #229
Fixes #234 by providing an appropriate error message
Unfortunately, we cannot easily fix #235, as it would require us to delete jobs (which we shouldn't do at the moment). I would dedicate the fix of #235 to the refactoring ticket of #244