Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick color from SVG image page #213

Open
kepi opened this issue May 27, 2022 · 1 comment
Open

Pick color from SVG image page #213

kepi opened this issue May 27, 2022 · 1 comment
Labels
comp: picker Picking colors from web pages type: idea Feature requests
Milestone
maybe

Comments

@kepi
Copy link
Owner

kepi commented May 27, 2022

Doesn't work on single svg page, i.e. https://igloonet.cz/static/tucnak-cb2faca690aabb6ac83f0cd5035801a5.svg

Looks like same problem that was present before on image pages, there is no html code around the image to inject code into etc.
@kepi kepi added impact: low type: idea Feature requests comp: picker Picking colors from web pages and removed impact: low labels May 27, 2022
@kepi kepi modified the milestones: v0.6.0, v0.6.x May 28, 2022
@kepi kepi mentioned this issue May 28, 2022
Open
@felix-seifert
Copy link

Local SVGs have the same issue.

@kepi kepi modified the milestones: v0.6.x, maybe Jul 1, 2024
@kepi kepi mentioned this issue Oct 21, 2024
Closed
kepi added a commit that referenced this issue Dec 7, 2024
@kepi
fix: handle error when picking from SVG root
019d7f7 
As tracked in #213 this is currently not possible, so display some
friendly error with explanation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: picker Picking colors from web pages type: idea Feature requests
Projects
None yet
Milestone
maybe
Development

No branches or pull requests
2 participants
@kepi @felix-seifert