Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider relocating -Cpanic=abort logic #11

Open
kentfredric opened this issue Nov 20, 2019 · 0 comments
Open

Consider relocating -Cpanic=abort logic #11

kentfredric opened this issue Nov 20, 2019 · 0 comments
Labels
discussion ideas, thoughts and meta issues that may or may not eventually lead to some concrete change

Comments

@kentfredric
Copy link
Member

Currently there's this in src_configure:

https://github.com/gyakovlev/rust-dev-overlay/blob/5bde43d1f07f3cf55ab899ff394635a830ae182d/eclass/rust-crate.eclass#L138-L148

But that last part gets messed up if anybody does FEATURES=test USE=-test. That sounds odd, until you realize this is what USE=-* does :/

While of course we can say "Don't do that", we could also improve things if this flag wasn't defaulted to on globally. ( We could guard against this with RESTRICT="!test? ( test )", but doing that for hundreds of packages is pain ... especially when I'm using RESTRICT as the indicator I need to revisit the package to add tests in the first place :D )

This will especially matter when we're installing binary executables, we don't want the nature of those to be different simply because they were built by somebody who was wanting it tested.

Though the downside of that of course is, when we do ship binaries and build tests, the compile will have to do most of it twice, once for the binaries with -Cpanic=abort, and once for the tests ( without -Cpanic=abort ).

@kentfredric kentfredric added the discussion ideas, thoughts and meta issues that may or may not eventually lead to some concrete change label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion ideas, thoughts and meta issues that may or may not eventually lead to some concrete change
Projects
None yet
Development

No branches or pull requests

1 participant