Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more message types we can ignore #8

Open
jimdigriz opened this issue Apr 9, 2021 · 1 comment
Open

more message types we can ignore #8

jimdigriz opened this issue Apr 9, 2021 · 1 comment

Comments

@jimdigriz
Copy link

Some of my work involved recently hooking up to an vintage Supermicro X10DRX (apparently Firmware Revision: 01.91, Firmware Build Time: 03/06/2015), so faced with the choice of Java or revisiting the horrific memories of this project, the latter won only as I suspect I can rebury those memories with hard liqueur :)

I have zero expectation the project is updated, this is more for others facing a similar dilemma, but there seemed to be two other (ignorable) message codes in the mix when connecting.

Providing as a diff, as reforking/PR would reopen those wounds too much, applying the following to your bmc-support branch helps get things moving for this board:

alex@aineko:~/src/noVNC$ git diff
diff --git a/core/rfb.js b/core/rfb.js
index 0386886..4040d2e 100644
--- a/core/rfb.js
+++ b/core/rfb.js
@@ -622,6 +622,7 @@
                     break;
                 case 'connected':
                     Util.Error("Failed while connected: " + fullmsg);
+                    Util.Debug("sock.rQslice(0, 30): " + this._sock.rQslice(0, 30));
                     break;
                 case 'connecting':
                     Util.Error("Failed when connecting: " + fullmsg);
@@ -896,6 +897,7 @@
 
         // authentication
         _negotiate_aten_auth: function () {
+this._rfb_password = 'ADMIN:ADMIN';
             var aten_sep = this._aten_password_sep;
             var aten_auth = this._rfb_password.split(aten_sep);
             if (aten_auth.length < 2) {
@@ -1527,6 +1529,14 @@
                         Util.Debug("ATEN iKVM Get Viewer Lang");
                         this._sock.rQskipBytes(8);
                         return true;
+
+                    case 77:
+                        this._sock.rQskipBytes(4);
+                        return true;
+
+                    case 118:
+                        this._sock.rQskipBytes(14);
+                        return true;
                 }
             }

The password entering prompt latches and does not try to actually use the details for me, so hence the hardcoding used and to help show others how to at least get something working.

@jimdigriz
Copy link
Author

jimdigriz commented Apr 10, 2021

...though of course just updating the BMC/IPMI firmware provides you with a built-in HTML5 option for remote controlling this board which means you do not have to use noVNC anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant