In this step, you will commit your changes, and create a pull request. This will kick off continuous integration and coverage reporting, which you can see from your pull request.
- Take a look at:
You can see that the build is successfully passing, but the overall coverage is pretty low.
- Commit your new unit tests from the previous step
to your fork of
catinabox
:
user@host:~$ git commit -a
- When you are happy with your commit and your changes, push them back to your fork:
user@host:~$ git push origin tutorial_wip
-
Visit github and open a new pull request:
-
Click on the
Pull requests
tab -
Click the
New pull request
button -
Click on the
compare:
drop down and select your branch in your fork. -
Click the
Create pull request
button. This will give you a chance to fill in the subject and description of your pull request. -
Click
Create pull request
to create your pull request.
More information is available in the github docs on creating pull requests.
-
As soon as the pull request is created, you will see three checks run:
-
Travis CI - Running all tests for python 2.7
-
Travis CI - Running all tests for python 3.4
-
Coveralls measuring the test coverage for your branch
-
If you see a build failure, you can run all tests locally:
user@host:~$ python setup.py test
However if the failure is with the other major version of python (e.g. you are running 3.4 locally but the 2.7 build broke) you will not be able to reproduce the failure.