Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide precompiled binary spm package #232

Open
ilendemli opened this issue Jan 19, 2024 · 2 comments
Open

provide precompiled binary spm package #232

ilendemli opened this issue Jan 19, 2024 · 2 comments
Labels

Comments

@ilendemli
Copy link

ilendemli commented Jan 19, 2024

Hey!

As the title states, it would be awesome if you could provide a spm package using the precompiled xcframeworks.
The reason being to improve compilation time of projects using pulse. You can check out my solution here: https://github.com/ilendemli/pulse-spm. A GitHub action would bundle a binary swift package out of the release from this repo.

@kean kean added the feature label Feb 19, 2024
@kean
Copy link
Owner

kean commented Feb 19, 2024

Hey, that's an interesting idea. I already ship pre-compiled frameworks with every release, but, of course, they aren't available via SPM. Do you know if there are any alternative ways of doing it and preferably keeping it in the same repo?

@ilendemli
Copy link
Author

ilendemli commented Feb 19, 2024

It might be possible to have it in the same repo but it is more beneficial to have a separate repo. Keeping it in the same repo would require for the end user to fetch the whole repo with code that is not used. Having a separate repo is better imo and it would automatically update itself using GitHub actions.

EDIT: I would firstly suggest for you to upload Pulse.xcframework and PulseUI.xcframework as separated zip files here (separating iOS and all-platform archives if necessary). Then you could create an GitHub action to push a Package.swift pointing to the xcframework zip archives in this repo to another repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants