Skip to content

Commit

Permalink
Merge branch 'master' into nightly
Browse files Browse the repository at this point in the history
  • Loading branch information
regisb committed Jan 18, 2023
2 parents 4da32ab + ac1a875 commit 0f67506
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/20230106_163518_regis_fix_example_com_links.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- 💥[Bugfix] Fix "example.com" links in registration emails. This is a breaking change for platforms that have modified the "id" field of the LMS site object in the database. These platforms should set `SITE_ID=1` in the common settings via a plugin. (by @regisb)
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Bugfix] Fix HTML component editing in studio by cherry-picking [upstream fix](https://github.com/openedx/edx-platform/pull/31500). (by @regisb)
1 change: 1 addition & 0 deletions changelog.d/20230117_165024_regis_cors_whitelist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Improvement] Resolve `CORS_ORIGIN_WHITELIST` warnings that pollute the LMS and CMS logs. As far as we know they were not causing any issue, apart from being a nuisance. (by @regisb)
1 change: 1 addition & 0 deletions tutor/templates/apps/openedx/settings/cms/production.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
ENV_TOKENS.get("CMS_BASE"),
"cms",
]
CORS_ORIGIN_WHITELIST.append("{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ CMS_HOST }}")

# Authentication
SOCIAL_AUTH_EDX_OAUTH2_KEY = "{{ CMS_OAUTH2_KEY_SSO }}"
Expand Down
1 change: 1 addition & 0 deletions tutor/templates/apps/openedx/settings/lms/production.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
FEATURES["PREVIEW_LMS_BASE"],
"lms",
]
CORS_ORIGIN_WHITELIST.append("{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}")

{% if ENABLE_HTTPS %}
# Properly set the "secure" attribute on session/csrf cookies. This is required in
Expand Down
4 changes: 4 additions & 0 deletions tutor/templates/apps/openedx/settings/partials/common_all.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@
},
}

# The default Django contrib site is the one associated to the LMS domain name. 1 is
# usually "example.com", so it's the next available integer.
SITE_ID = 2

# Contact addresses
CONTACT_MAILING_ADDRESS = "{{ PLATFORM_NAME }} - {% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}"
DEFAULT_FROM_EMAIL = ENV_TOKENS.get("DEFAULT_FROM_EMAIL", ENV_TOKENS["CONTACT_EMAIL"])
Expand Down
4 changes: 4 additions & 0 deletions tutor/templates/build/openedx/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,12 @@ WORKDIR /openedx/edx-platform
RUN git config --global user.email "[email protected]" \
&& git config --global user.name "Tutor"

{%- if patch("openedx-dockerfile-git-patches-default") %}
# Custom edx-platform patches
{{ patch("openedx-dockerfile-git-patches-default") }}
{%- else %}
# Patch edx-platform
{%- endif %}

{# Example: RUN curl -fsSL https://github.com/openedx/edx-platform/commit/<GITSHA1> | git am #}
{{ patch("openedx-dockerfile-post-git-checkout") }}
Expand Down

0 comments on commit 0f67506

Please sign in to comment.