✨ Update to Kubernetes 1.30.0 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
dco-signoff: yes
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
|
/cc @sttts @mjudeikis |
|
/lgtm |
|
LGTM label has been added. Git tree hash: b21837d43b06d75761f1382c26b8a860b8060d58
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is another step towards the 1.30 rebase for kcp. I've updated all dependencies to 1.30 (and corresponding kcp-dev/apimachinery).
I reviewed the output of
git diff v1.28.0 v1.30.0 -- cmd/client-gen/ cmd/informer-gen/ cmd/lister-gen/and the only change to generated code seems to be kubernetes/kubernetes@9c4651b. I've adapted our generated informer code to also set the transform func, but I'll be honest: I'm not sure I've done this right and would appreciate a bit of scrutiny on this. I'm specifically not sure if it should have been wrapped in{{if not .useUpstreamInterfaces -}}or not.Related issue(s)
Fixes #
Release Notes