Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse error for queries is not specific enough #231

Open
2 tasks done
blcham opened this issue Apr 19, 2024 · 4 comments · May be fixed by #241
Open
2 tasks done

Parse error for queries is not specific enough #231

blcham opened this issue Apr 19, 2024 · 4 comments · May be fixed by #241

Comments

@blcham
Copy link
Contributor

blcham commented Apr 19, 2024 •
edited by MSattrtand
Loading

In a module such as ApplyConstruct, when it fails due to a parse error, it says something like:
image

The issue is that I am not able to find out why the parse error occurred, as I do not see the original query. The query should be logged as well (or maybe even pointing somehow to where the error exactly occurs so the user does not necessarily need to use an external editor to find it out from the line/column number).

A/C:

  • within "this issue thread", it is shown how logging of parse error looked before and how it looks now so I can compare
  • parse error related to validation constraints is improved as well and shown here
@blcham
Copy link
Contributor Author

blcham commented Jun 30, 2024 •
edited
Loading

You can test it on pipeline https://github.com/kbss-cvut/s-pipes/blob/54dfb128d59584980a78be036965ab089d164dfa/doc/examples/hello-world/hello-world.sms.ttl#L53C1-L53C1 as follows:

  1. deploy Spipes
  2. run script hello-world
  3. modify apply construct in https://github.com/kbss-cvut/s-pipes/blob/54dfb128d59584980a78be036965ab089d164dfa/doc/examples/hello-world/hello-world.sms.ttl#L53C1-L53C1 to make parse error in the query
  4. run script hello-world again to see the parse error -- AND this is what needs to be improved

@blcham blcham mentioned this issue Jul 4, 2024
Closed
@blcham
Copy link
Contributor Author

blcham commented Jul 5, 2024

Another queries (validation queries) can be tested here

blcham added a commit that referenced this issue Jul 5, 2024
@blcham
[#231] Improve logging for query parse error in ApplyConstructModule
b516e7a
@blcham blcham linked a pull request Jul 5, 2024 that will close this issue
Open
blcham added a commit that referenced this issue Jul 5, 2024
@blcham
[#231] Improve logging for query parse error in ApplyConstructModule
9a02c94
@MSattrtand
Copy link
Collaborator

How the log looks now using the constraint validation as an example:
image
image
The image is split into two parts because the displayed query is long.

@blcham blcham moved this from Todo to In progress in SPipes related projects Jul 9, 2024
@blcham blcham moved this from In progress to Todo in SPipes related projects Jul 9, 2024
@blcham blcham moved this from Todo to In progress in SPipes related projects Jul 9, 2024
MSattrtand pushed a commit that referenced this issue Jul 10, 2024
[#231] Logs now output incorrect line whet QueryParseException happens
90b3408
@MSattrtand
Copy link
Collaborator

Logs now output incorrect line when QueryParseException happens. Examples:
image
image
image

MSattrtand pushed a commit that referenced this issue Jul 14, 2024
[#231] Fixed unintended crash
1e92e3f
blcham pushed a commit that referenced this issue Jul 15, 2024
@blcham
[#231] Logs now output incorrect line whet QueryParseException happens
4745de5
blcham pushed a commit that referenced this issue Jul 15, 2024
@blcham
[#231] Fixed unintended crash
cd2a0bb
blcham pushed a commit that referenced this issue Jul 15, 2024
@blcham
[#231] Improve logs readability
cf87630
blcham pushed a commit that referenced this issue Jul 17, 2024
@blcham
[#231] Improve logs readability
08a725c
blcham pushed a commit that referenced this issue Jul 17, 2024
@blcham
[#231] Improve logs readability
744a106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SPipes related projects
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve logging for query parse error in ApplyConstructModule kbss-cvut/s-pipes
2 participants
@blcham @MSattrtand