Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cz.cvut.kbss.ontodriver.model.MultilingualString to distingush it better from cz.cvut.kbss.jopa.model.MultilingualString #288

Closed
luxbe opened this issue Nov 21, 2024 · 0 comments · Fixed by #293
Closed

Rename cz.cvut.kbss.ontodriver.model.MultilingualString to distingush it better from cz.cvut.kbss.jopa.model.MultilingualString #288

luxbe opened this issue Nov 21, 2024 · 0 comments · Fixed by #293
Assignees
@ledsoft
Milestone
2.2.1

Comments

@luxbe
Copy link
Contributor

luxbe commented Nov 21, 2024

Currently, there exist two classes of MultilingualString - one in the ontodriver package and one within JOPA. The one in JOPA is more tailored towards the actual application use cases, while the ontodriver one mainly allows for support of MultilingualStrings in referenced lists.

As a user, this can be confusing. When I want to use a MultilingualString, I suddently have to options. One possibility would be to rename the MultilingualString within the ontodriver package to BaseMultilingualString, CoreMultilingualString or even ReferencedListMultilingualString to really drill down on that Use-Case.

It might also make sense for the MultilingualString within the jopa package to inherit from the one within the ontodriver.
@ledsoft ledsoft self-assigned this Dec 11, 2024
ledsoft added a commit that referenced this issue Dec 11, 2024
@ledsoft
[GH-288] Rename MultilingualString in OntoDriver to Translations.
a47a9e9 
Should prevent confusion with MultilingualString in JOPA API.
@ledsoft ledsoft mentioned this issue Dec 11, 2024
Merged
@ledsoft ledsoft linked a pull request Dec 11, 2024 that will close this issue
Gh#288 rename ontodriver multilingualstring #293
Merged
ledsoft added a commit that referenced this issue Dec 11, 2024
@ledsoft
[GH-288] Rename MultilingualString in OntoDriver to Translations.
ba9ac57 
Should prevent confusion with MultilingualString in JOPA API.
@ledsoft ledsoft added this to the 2.2.1 milestone Dec 12, 2024
@ledsoft ledsoft closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ledsoft ledsoft

Labels
None yet
Projects
None yet
Milestone
2.2.1
Development

Successfully merging a pull request may close this issue.

Gh#288 rename ontodriver multilingualstring kbss-cvut/jopa
2 participants
@ledsoft @luxbe