Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The refresh button behaves strangely in fault trees #593

Closed
grotskat opened this issue Sep 17, 2024 · 5 comments · Fixed by #626
Closed

The refresh button behaves strangely in fault trees #593

grotskat opened this issue Sep 17, 2024 · 5 comments · Fixed by #626
Assignees
@grotskat

Comments

@grotskat
Copy link
Collaborator

grotskat commented Sep 17, 2024 •
edited
Loading

The refresh button is behaving strangely:

  • For some fault trees it does nothing when pressed,

  • and for some trees it will change to the previous filled value (from 300 to 100, for example).

  • For some fault trees it does nothing when pressed,

image
image
image
image

  • and for some trees it will change to the previous filled value (from 300 to 100, for example).

image
image
image
image
@blcham
Copy link
Contributor

blcham commented Sep 17, 2024

Could you be more specific? How to simulate the issue (on what trees should i click)?

@grotskat
Copy link
Collaborator Author

@blcham I added examples.

@blcham blcham assigned kostobog and unassigned blcham Sep 18, 2024
@kostobog
Copy link
Collaborator

kostobog commented Oct 8, 2024

Image

kostobog added a commit that referenced this issue Oct 8, 2024
@kostobog
[Fix #593] Fix jsonld context for system in faultTreeModel.tsx
a309e74
kostobog added a commit that referenced this issue Oct 8, 2024
@kostobog
[Fix #593] Fix reset MOH button and rendering the states of the MOH i…
f33f105 
…nput field.
@kostobog kostobog mentioned this issue Oct 8, 2024
Merged
@blcham blcham closed this as completed in 2495403 Oct 8, 2024
@blcham blcham reopened this Oct 8, 2024
@blcham
Copy link
Contributor

blcham commented Oct 8, 2024

@grotskat reopening this issue just to test it properly. Please have a look at how it should work as explained in this PR:
#626

If you have any suggestions on how to make it better, write It here please . Otherwise, let's close this issue if it works correctly.

@blcham blcham assigned grotskat and unassigned kostobog Oct 8, 2024
@grotskat
Copy link
Collaborator Author

It works correctly and it makes sense to me.
@blcham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grotskat grotskat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix moh reset button in fault tree editor kbss-cvut/fta-fmea-ui
3 participants
@blcham @kostobog @grotskat