Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can't use operational failure rate if it is missing in the data #525

Open
3 tasks done
kostobog opened this issue Jul 12, 2024 · 8 comments
Open
3 tasks done
Assignees

Comments

@kostobog
Copy link
Collaborator

kostobog commented Jul 12, 2024

Operational failure rate cannot be used if it is not present in the data.

Image

Tasks:

@kostobog kostobog changed the title User can use operational failure rate if it is missing in the data User can't use operational failure rate if it is missing in the data Jul 14, 2024
@kostobog kostobog self-assigned this Jul 15, 2024
@blcham
Copy link
Contributor

blcham commented Jul 17, 2024

Currently this was done by workaround -- https://github.com/kbss-cvut/ava-analytics/pull/39, which should be properly fixed in #532.

@blcham blcham assigned kostobog and unassigned kostobog Jul 17, 2024
@blcham
Copy link
Contributor

blcham commented Jul 17, 2024

@kostobog so does it work now ?

@kostobog
Copy link
Collaborator Author

@blcham
This works. User can user operational failure rate if it is not calculated yet.

First user has to click the tree evaluation button. Operational failure rates in the tree will be updated according to the value of min. operational hours field next to the button even if there is an error message that the tree could not be evaluate due to unspecified failure rates in some of of the leaf nodes.

To see the newly added operational failure rates in the SNS node the tree must reloaded. The tree could be reloaded in several ways:

  1. automatically if the tree was evaluated successfully without error messages for missing failure rates in leaf nodes
  2. by updating one of the nodes, e.g. change the name of change the failure rate selection or manual failure rate.
  3. exit the tree and open it again

@blcham
Copy link
Contributor

blcham commented Nov 19, 2024

@kostobog ok I guess the workaround you mentioned is good enough as it is, what do you think?
If so i suggest to close this issue.

@kostobog
Copy link
Collaborator Author

@blcham
Open access workaround works but I am not sure if we want keep it?

Otherwise, I can improve user experience by reloading the tree even if there were missing failure rates at the leaf events. This way the user will always need to only click the evaluate button to see the missing operational failure rates.

@blcham
Copy link
Contributor

blcham commented Nov 19, 2024

If it does not introduce other issues it would be better UX if you reload.

@blcham
Copy link
Contributor

blcham commented Nov 28, 2024

So we can close this issue if:

  • refresh of failed evaluation works
  • if the ticket about securing ava-analytics contains also adaptation of 23-ava see the issue

@blcham
Copy link
Contributor

blcham commented Nov 28, 2024

@kostobog please see my last comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants