Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize UI when editing events #417

Closed
3 tasks done
Tracked by #432
LaChope opened this issue Jun 17, 2024 · 5 comments
Closed
3 tasks done
Tracked by #432

Harmonize UI when editing events #417

LaChope opened this issue Jun 17, 2024 · 5 comments
Assignees

Comments

@LaChope
Copy link
Collaborator

LaChope commented Jun 17, 2024

The merge of #396 and #367 led to inconsistent UI when editing nodes.

  • @Kasmadei For basic nodes, there are now 2 ways to edit the failure rate (we want only the radio, not input field) (also described in Manually defined failure rate for BASIC node #451)
  • @LaChope The save button should be after the radio options (right now it is in between failure rate field and radio options)
  • @LaChope Open for discussion, but the "Description" field does not look nice at all to me

Image

@blcham

@Kasmadei
Copy link
Collaborator

First point: #463

@Kasmadei Kasmadei assigned LaChope and unassigned Kasmadei Jun 24, 2024
@blcham blcham assigned blcham and unassigned LaChope Jun 24, 2024
@blcham
Copy link
Contributor

blcham commented Aug 6, 2024

Current state:
image

@blcham blcham assigned grotskat and unassigned blcham Sep 30, 2024
@grotskat
Copy link
Collaborator

grotskat commented Sep 30, 2024

@blcham

  • Root node

  • 2x Event name

image

  • the separator is between failure rates (Is that right?)

image

  • after changing the Gate type, the SAVE button is under failure rates (Is that right?)

image

@blcham
Copy link
Contributor

blcham commented Oct 10, 2024

We agreed to:

  • have the SAVE/DISCARD button right above the separator, which is right below failure rates.
  • have separator below MOH

@grotskat
Copy link
Collaborator

grotskat commented Nov 5, 2024

It works.

@grotskat grotskat closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants