You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #426 I noticed that there is no convenient alternative to call \Redmine\Http\HttpClient::request() because one has to implement the \Redmine\Http\Request interface beforehand.
Internally we are using the class \Redmine\Http\HttpFactory to create Request and Response instances. This factory class is marked as internal. I propose to make this class publicly available to make the use of \Redmine\Http\HttpClient::request() much more easier.
See also #401 (comment). The HttpFactory will reduce the needed code to:
While working on #426 I noticed that there is no convenient alternative to call
\Redmine\Http\HttpClient::request()
because one has to implement the\Redmine\Http\Request
interface beforehand.Internally we are using the class
\Redmine\Http\HttpFactory
to createRequest
andResponse
instances. This factory class is marked as internal. I propose to make this class publicly available to make the use of\Redmine\Http\HttpClient::request()
much more easier.See also #401 (comment). The
HttpFactory
will reduce the needed code to:#391 proposes the deprecation of this methods:
Redmine\Client\Client::getLastResponseStatusCode()
Redmine\Client\Client::getLastResponseContentType()
Redmine\Client\Client::getLastResponseBody()
But publishing
HttpFactory
will allow us to deprecate even more methods:Redmine\Client\Client::requestGet()
Redmine\Client\Client::requestPost()
Redmine\Client\Client::requestPut()
Redmine\Client\Client::requestDelete()
Deprecating this methods was also kept in mind while designing the
\Redmine\Http\HttpClient::request()
method, see #341.The text was updated successfully, but these errors were encountered: