From 024a4222fe25043faf619d8064c794955115cff4 Mon Sep 17 00:00:00 2001 From: Kazuyuki Tanimura Date: Tue, 11 Jun 2024 12:48:31 -0700 Subject: [PATCH] address review comments --- .../main/spark-3.2/org/apache/comet/shims/CometExprShim.scala | 2 +- .../main/spark-3.3/org/apache/comet/shims/CometExprShim.scala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spark/src/main/spark-3.2/org/apache/comet/shims/CometExprShim.scala b/spark/src/main/spark-3.2/org/apache/comet/shims/CometExprShim.scala index d29a5bcf0..44c1ceb69 100644 --- a/spark/src/main/spark-3.2/org/apache/comet/shims/CometExprShim.scala +++ b/spark/src/main/spark-3.2/org/apache/comet/shims/CometExprShim.scala @@ -34,7 +34,7 @@ trait CometExprShim { } protected def isTimestampNTZType(dt: DataType): Boolean = - dt.typeName == "timestamp_ntz" => true // `TimestampNTZType` is private + dt.typeName == "timestamp_ntz" // `TimestampNTZType` is private protected def evalMode(c: Cast): CometEvalMode.Value = CometEvalMode.fromBoolean(c.ansiEnabled) } diff --git a/spark/src/main/spark-3.3/org/apache/comet/shims/CometExprShim.scala b/spark/src/main/spark-3.3/org/apache/comet/shims/CometExprShim.scala index d3a21acdb..aa6db06d8 100644 --- a/spark/src/main/spark-3.3/org/apache/comet/shims/CometExprShim.scala +++ b/spark/src/main/spark-3.3/org/apache/comet/shims/CometExprShim.scala @@ -34,7 +34,7 @@ trait CometExprShim { } protected def isTimestampNTZType(dt: DataType): Boolean = - dt.typeName == "timestamp_ntz" => true // `TimestampNTZType` is private + dt.typeName == "timestamp_ntz" // `TimestampNTZType` is private protected def evalMode(c: Cast): CometEvalMode.Value = CometEvalMode.fromBoolean(c.ansiEnabled) }