Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better assign of cas port #25

Open
nstylianides opened this issue Sep 27, 2019 · 0 comments
Open

better assign of cas port #25

nstylianides opened this issue Sep 27, 2019 · 0 comments

Comments

@nstylianides
Copy link

A. CAS Server Port configuration
I suggest the following change at line 151

change: this.cas_port = parsed_cas_url.protocol === 'http:' ? 80 : 443;

to:

this.cas_port = (parsed_cas_url.port!=null)?parsed_cas_url.port:(parsed_cas_url.protocol === 'http:' ? 80 : 443);

B. REST API
I suggest to enhance this package to support also the REST API. How can we push code on github and npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant