Indexes are never created on SQLite and mysql stores

[jmfernandez]

When a SQLite store is initialized, indexes are never created. If you see at next code fragment:

perlrdf/RDF-Trine/lib/RDF/Trine/Store/DBI/SQLite.pm

Lines 125 to 135 in 2db05bf

	sub init {
	my $self = shift;
	my $dbh = $self->dbh;
	my $name = $self->model_name;
	$self->SUPER::init();
	my $id = $self->_mysql_hash( $name );
	my $table = "Statements${id}";
	local($dbh->{AutoCommit}) = 0;
	unless ($self->_table_exists($table)) {
	$dbh->do( "CREATE INDEX idx_${name}_spog ON Statements${id} (Subject,Predicate,Object,Context);" ) || do { $dbh->rollback; return };

$self->SUPER::init(); is called before, creating the needed tables. So, check in line 134 should be the opposite, something like:

        if ($self->_table_exists($table)) {

BTW, in the case of mysql store, init method has some messed code.

[kasei]

Thanks for reporting this. That does seem like an issue. I can try to commit a fix, but as you noticed, the DBI code in RDF::Trine is a bit of a mess, and not well maintained.

Development on RDF::Trine has mostly ended at this point, with most new work going on in the Attean project (which despite what seems like an accidental copy-commit, does not have a DBI storage engine). If you have any interest/ability to submit changes to this (or Attean) to improve the mysql code, I'd be more than happy to merge them.

Thanks again.