From 99908857f255e39bd79453b4864952ac4f703e6e Mon Sep 17 00:00:00 2001 From: "Wataru.Kasahara" Date: Mon, 12 Feb 2024 13:26:17 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20page=20title=20=E3=82=92=20page=20c?= =?UTF-8?q?omponent=20=E3=81=AB=E7=A7=BB=E5=8B=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../features/top/containers/top/top.component.html | 2 -- src/app/features/top/containers/top/top.component.ts | 5 ++--- src/app/features/top/top.component.ts | 12 +++++++++--- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/app/features/top/containers/top/top.component.html b/src/app/features/top/containers/top/top.component.html index 8715bdef..6014eb24 100644 --- a/src/app/features/top/containers/top/top.component.html +++ b/src/app/features/top/containers/top/top.component.html @@ -1,5 +1,3 @@ - -
diff --git a/src/app/features/top/containers/top/top.component.ts b/src/app/features/top/containers/top/top.component.ts index 71468c64..dff9f51a 100644 --- a/src/app/features/top/containers/top/top.component.ts +++ b/src/app/features/top/containers/top/top.component.ts @@ -1,8 +1,8 @@ -import { ChangeDetectionStrategy, Component } from '@angular/core'; import { NgFor } from '@angular/common'; -import { snsList } from '../../data/sns'; +import { ChangeDetectionStrategy, Component } from '@angular/core'; import { ExternalLinkDirective } from '../../../../shared/external-link/directives/external-link.directive'; import { PageTitleComponent } from '../../../../shared/page-title/page-title/page-title.component'; +import { snsList } from '../../data/sns'; @Component({ selector: 'app-top', @@ -13,7 +13,6 @@ import { PageTitleComponent } from '../../../../shared/page-title/page-title/pag imports: [PageTitleComponent, NgFor, ExternalLinkDirective], }) export class TopComponent { - readonly name = 'kasaharu (Wataru KASAHARA)'; readonly myInfoList: string[] = ['Web Frontend Engineer', 'Angular Japan User Group Staff']; readonly snsList = snsList; } diff --git a/src/app/features/top/top.component.ts b/src/app/features/top/top.component.ts index 8a8ee785..1f9e1676 100644 --- a/src/app/features/top/top.component.ts +++ b/src/app/features/top/top.component.ts @@ -1,10 +1,16 @@ import { ChangeDetectionStrategy, Component } from '@angular/core'; +import { PageTitleComponent } from '../../shared/page-title/page-title/page-title.component'; import { TopComponent } from './containers/top/top.component'; @Component({ - template: '', + template: ` + + + `, changeDetection: ChangeDetectionStrategy.OnPush, standalone: true, - imports: [TopComponent], + imports: [TopComponent, PageTitleComponent], }) -export class TopPageComponent {} +export class TopPageComponent { + readonly name = 'kasaharu (Wataru KASAHARA)'; +}