Refactor ->slurp XS

bindings/perl/3.xs

@@ -177,13 +177,14 @@ slurp(self, filename, ...)
         else {
             buf = swish_io_slurp_file_len((xmlChar*)filename, buflen, binmode);
         }
-        RETVAL = newSV(0);
-        // warn("%s re-using SV with strlen %d\n", filename, (int)buflen);
         if (buf[buflen] != '\0') {
             croak("Buffer was not NUL-terminated (buflen=%d)\n", (int)buflen);
         }
-        sv_usepvn_flags(RETVAL, (char*)buf, buflen, SV_SMAGIC | SV_HAS_TRAILING_NUL);
-        swish_memcount_dec(); // must do manually since Perl will free() buf
+        // copy our buf into a new SV
+        // this is somewhat inefficient in terms of malloc/free, but re-using our pointer
+        // is buggy on some Perls.
+        RETVAL = newSVpvn(buf, buflen);
+        swish_xfree(buf);
 
     OUTPUT:
         RETVAL

bindings/perl/Changes

@@ -1,5 +1,8 @@
 Revision history for SWISH::3, libswish3 Perl bindings.
 
+1.000016 xxx
+ - slurp() now creates new SV with copy of C string rather than re-using C pointer.
+
 1.000015 01 April 2017
  - segfault fix in libswish3.c via https://github.com/karpet/libswish3/pull/1
  - fix Perl test failures related to null-termination of re-used char* pointer in SV*.

bindings/perl/lib/SWISH/3.pm

@@ -4,7 +4,7 @@ use 5.008_003;
 
 package SWISH::3;
 
-our $VERSION = '1.000015';
+our $VERSION = '1.000016';
 my $version = $VERSION;
 $VERSION = eval $VERSION;    # numerify