Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiplication of characters #70

Merged
merged 10 commits into from
Nov 29, 2023
Merged

Allow multiplication of characters #70

merged 10 commits into from
Nov 29, 2023

Conversation

kalmarek
Copy link
Owner

and sort the character table

CC: @blegat

@kalmarek kalmarek force-pushed the mk/characters_ring_str branch 2 times, most recently from b032166 to 17c3f08 Compare November 28, 2023 16:10
@kalmarek kalmarek force-pushed the mk/characters_ring_str branch from 17c3f08 to ace63bc Compare November 28, 2023 20:13
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (15ddfeb) 87.89% compared to head (2847813) 87.88%.

Files Patch % Lines
src/Characters/class_functions.jl 90.47% 4 Missing ⚠️
src/Characters/character_tables.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   87.89%   87.88%   -0.01%     
==========================================
  Files          20       20              
  Lines        1330     1354      +24     
==========================================
+ Hits         1169     1190      +21     
- Misses        161      164       +3     
Flag Coverage Δ
unittests 87.88% <92.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalmarek kalmarek merged commit 3a18e8d into master Nov 29, 2023
19 of 20 checks passed
@kalmarek kalmarek deleted the mk/characters_ring_str branch November 29, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant