Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

row or column based direct summands? #39

Open
kalmarek opened this issue Sep 16, 2021 · 1 comment
Open

row or column based direct summands? #39

kalmarek opened this issue Sep 16, 2021 · 1 comment

Comments

@kalmarek
Copy link
Owner

@blegat
I think we just happen to do it row-based by a historical accident now (row_echelon_form). I think all of this should be rewritten to column_echelon_form anyway, but this is just internals; users will face row-based symmetry_adapted_basis I think it should be changed to column-based. Any objections?

@blegat
Copy link
Collaborator

blegat commented Sep 19, 2021

I use the fact that the output is in row-echelon here: https://github.com/jump-dev/SumOfSquares.jl/blob/master/src/Certificate/Symmetry/wedderburn.jl#L111
However, if it's just internal and the users get a row-based one I have no objection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants