An error in a 'before' task hook makes 'error' hooks complain about not being called in a 'after/error'

[robinbourianes-kalisio]

In this job for example : https://github.com/kalisio/c3x-arpege/blob/ef7bd729dcbcf14d435313904a683dd735603150/jobfile-arpege-0.1.js

If there's an error in connectFTP which is a before hook, then disconnectFTP called in the error hooks complains that it should only be called in a after/error hook as seen here
If the error happens in some of the after hooks, then error hooks work fine.

[claustres]

Also apply to some others hooks like

krawler/src/hooks/hooks.pg.js

Line 34 in b5f811b

if ((hook.type !== 'after') && (hook.type !== 'error')) {

krawler/src/hooks/hooks.docker.js

Line 31 in b5f811b

if ((hook.type !== 'after') && (hook.type !== 'error')) {

These restrictions are probably not required because we use the hook.data object available as well in a before hook, eg

krawler/src/hooks/hooks.mongo.js

Line 36 in b5f811b

export function disconnectMongo (options = {}) {

[robinbourianes-kalisio]

But there's a bug right ?
The hook complaining that it's not being run in an 'after/error' context IS called in an 'error' context.
It's as if when an error happen in a 'before' hook the hook.type field is not updated correctly.

[claustres]

Seems actually to be linked to this code part

krawler/src/utils.js

Line 136 in b5f811b

export function callOnHookItems (f) {

because the error hook type is lost when calling the hook function.

[claustres]

Closed by error, fixed bug by the commit was #92.