Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Money Filters? #129

Open
rjhankison opened this issue Jun 24, 2019 · 4 comments
Open

Support for Money Filters? #129

rjhankison opened this issue Jun 24, 2019 · 4 comments

Comments

@rjhankison
Copy link

Hello again!

We're still getting a lot of great feedback for this library! One question that has come up from our customers is support for the "money" filter.

Is this something you're considering adding support for? Do you already offer support and I just missed it?

Thanks in advance for your response!

Best,
-Rich

@sanmai
Copy link
Collaborator

sanmai commented Jun 25, 2019

That's an interesting feature and I will happily review a PR with it implemented.

@rjhankison
Copy link
Author

Hey @sanmai -- sounds good. I may give this a go.

Do you have a PR requirements for me to take a look at? Unit tests? Dependency restrictions?

@sanmai
Copy link
Collaborator

sanmai commented Jul 27, 2019

CI must pass, and there's some basic guidance when you make a PR.

@dotmbf
Copy link

dotmbf commented Dec 21, 2020

add a custom filter and use https://github.com/brick/money

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants