Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Include #89

Open
maicolbruski opened this issue Nov 22, 2017 · 14 comments · May be fixed by #125
Open

Dynamic Include #89

maicolbruski opened this issue Nov 22, 2017 · 14 comments · May be fixed by #125
Labels
feature request help wanted

Comments

@maicolbruski
Copy link

Hi,

It's possible create a include dynamic with a custom variable?
For example in loop:

{% for item in files %} 
   {% include item.file %}
{% endfor %}

Tks.
@sanmai
Copy link
Collaborator

sanmai commented Dec 5, 2017

It seems like this is possible in the stock Liquid, or in the Jekyll, at very least:

{% include {{ my_variable }} %}

I haven't checked yet if we are handling this case in PHP Liquid.

@maicolbruski
Copy link
Author

In PHP Liquid does`t work. =(

@maicolbruski
Copy link
Author

nothing yet?

@sanmai
Copy link
Collaborator

sanmai commented Jul 24, 2018

It doesn't seem like there was any volunteer.

@HappyLDE
Copy link

Hello, I really need this:
{% include {{ my_variable }} %}

There seems to be a solution made for this fork:
harrydeluxe#14

Can someone make it happen? Much appreciated

@sanmai sanmai linked a pull request May 30, 2019 that will close this issue
Open
@sanmai
Copy link
Collaborator

sanmai commented May 30, 2019

Nice find! I've made a PR for time being, but it'll require more work.

@sanmai sanmai reopened this May 30, 2019
@HappyLDE
Copy link

HappyLDE commented Jul 7, 2019

Any news for this?

@sanmai
Copy link
Collaborator

sanmai commented Jul 9, 2019

I wonder if you can try you hand with this job. What do you think?

My hands are tied at least until autumn.

@HappyLDE
Copy link

I have no idea what to do

@sanmai
Copy link
Collaborator

sanmai commented Jul 14, 2019

I'd start with taking tests from #125, and then proceed with other changes, except for static variables.

@HappyLDE
Copy link

I will take a look at this!

@sanmai sanmai mentioned this issue Jul 29, 2019
Open
@thomasgreen
Copy link

Hi - is there any update on a fix for this?

@sanmai
Copy link
Collaborator

sanmai commented Nov 14, 2019

I'm here to review any PR with this feature.

@miky9585
Copy link

any news after 2 years?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic Includes chros73/php-liquid
5 participants
@sanmai @HappyLDE @maicolbruski @miky9585 @thomasgreen