Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selenium dependency #290

Open
Acanis87 opened this issue Dec 2, 2024 · 1 comment
Open

Remove selenium dependency #290

Acanis87 opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
dev for dev branch good first issue Good for newcomers

Comments

@Acanis87
Copy link

Acanis87 commented Dec 2, 2024

Hey,

Driverless isnt using Selenium (anymore?), but its still an dependency:

Traceback (most recent call last):
File "C:\Users......\main.py", line 3, in
from selenium_driverless import webdriver
File "C:\Users.......venv\Lib\site-packages\selenium_driverless\webdriver.py", line 43, in
from selenium_driverless.scripts.switch_to import SwitchTo
File "C:\Users.......venv\Lib\site-packages\selenium_driverless\scripts\switch_to.py", line 29, in
from selenium_driverless.types.target import TargetInfo, Target
File "C:\Users.......venv\Lib\site-packages\selenium_driverless\types\target.py", line 26, in
from selenium_driverless.utils.utils import safe_wrap_fut
File "C:\Users.........venv\Lib\site-packages\selenium_driverless\utils\utils.py", line 10, in
import selenium
ModuleNotFoundError: No module named 'selenium'

Would be nice to be able to get rid of Selenium :)

@kaliiiiiiiiii
Copy link
Owner

Thanks!

To refactor:


def sel_path():
return os.path.dirname(selenium.__file__) + "/"


requirements = ['selenium~=4.6', "cdp-socket>=1.2.5", "numpy", "scipy~=1.7", "aiofiles",

@kaliiiiiiiiii kaliiiiiiiiii changed the title Selenium Dependency Remove selenium dependency Dec 2, 2024
@kaliiiiiiiiii kaliiiiiiiiii self-assigned this Dec 2, 2024
@kaliiiiiiiiii kaliiiiiiiiii added good first issue Good for newcomers dev for dev branch labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev for dev branch good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants