Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hard to understand about the description in filter features. #290

Open
beyondpie opened this issue Apr 8, 2024 · 1 comment
Open

hard to understand about the description in filter features. #290

beyondpie opened this issue Apr 8, 2024 · 1 comment

Comments

@beyondpie
Copy link
Collaborator

Hi Kai,

Here is the description of filter features:

If inplace = False, return a boolean index mask that does filtering, where True means that the feature is kept, False means the feature is removed. Otherwise, store this index mask directly to .var['selected'].

What's the meaning of "Otherwise" here? inplace should only be True or False, right?

Thanks!
Songpeng
@beyondpie beyondpie changed the title hard to understand hard to understand about the description in filter features. Apr 8, 2024
@kaizhang
Copy link
Owner

kaizhang commented Apr 9, 2024

"otherwise" means "if inplace=True"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaizhang @beyondpie