Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: KC: Bulk operations for connectors #335

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Nilumilak
Copy link
Member

@Nilumilak Nilumilak commented May 1, 2024

Also:

  • Added Pause button to the ActionsCell (before you could only Resume)
  • chevronDownIcon color was fixed

resolves #221

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

Also:
- Added Pause button to the ActionsCell (before you could only Resume)
- chevronDownIcon color was fixed
@Nilumilak Nilumilak added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes status/triage/completed Automatic triage completed area/connect Kafka Connect, its connectors labels May 1, 2024
@Nilumilak Nilumilak self-assigned this May 1, 2024
@Nilumilak Nilumilak requested a review from a team as a code owner May 1, 2024 17:11
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress and removed status/triage Issues pending maintainers triage labels May 1, 2024
@Haarolean Haarolean changed the title Bulk operations for connectors FE: KC: Bulk operations for connectors May 1, 2024
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label May 1, 2024
confirm(confirmMessage, async () => {
try {
await Promise.all(
selectedConnectors.map(({ connect, name }) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haarolean can we have an endpoint for this that does bulk delete so we don't need to do this multiple promises here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we sure can do that

frontend/src/lib/hooks/api/kafkaConnect.ts Outdated Show resolved Hide resolved
frontend/src/lib/hooks/api/kafkaConnect.ts Outdated Show resolved Hide resolved
@Haarolean Haarolean assigned Haarolean and unassigned Nilumilak May 16, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
@Haarolean Haarolean marked this pull request as draft October 7, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connect Kafka Connect, its connectors hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: KC: Bulk operations for connectors
3 participants