Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Messages: Explode partitions list in API #331

Merged
merged 3 commits into from
May 16, 2024

Conversation

Vixtir
Copy link
Contributor

@Vixtir Vixtir commented May 1, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
For not to exceed the max URL length by partition (&partitions=29&partitions=30) used collapsed form for search params (&partitions=29%2C30) with comma as separator

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Vixtir Vixtir requested a review from a team as a code owner May 1, 2024 07:23
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 1, 2024
@Vixtir Vixtir requested a review from Haarolean May 1, 2024 07:24
@Haarolean Haarolean linked an issue May 1, 2024 that may be closed by this pull request
@Haarolean Haarolean added scope/frontend Related to frontend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels May 1, 2024
@Haarolean Haarolean changed the title useMessageFilters - collapse partitions ids Messages: Explode partitions list in API May 16, 2024
@Haarolean Haarolean changed the title Messages: Explode partitions list in API FE: Messages: Explode partitions list in API May 16, 2024
@Haarolean Haarolean merged commit ba92bcb into main May 16, 2024
14 of 15 checks passed
@Haarolean Haarolean deleted the feat/collapse_partitions_id branch May 16, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages: Explode partitions list in API
3 participants