Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages: Explode partitions list in API #212

Closed
Haarolean opened this issue Mar 15, 2024 · 1 comment · Fixed by #331
Closed

Messages: Explode partitions list in API #212

Haarolean opened this issue Mar 15, 2024 · 1 comment · Fixed by #331
Assignees
@Vixtir
Labels
area/messages good first issue Up for grabs scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Milestone
1.1

Comments

@Haarolean
Copy link
Member

What

Within #47 API has been changed and multiple partitions are passed like &partitions=1&partitions=2&partitions=3 to backend. We need to use explode keyword in OpenAPI spec to make it possible to use &partitions=1,2,3 instead.

Why

Having topics with a considerable number of partitions can lead to problems. Imagine having 1000 partitions and having a need to search messages in all partitions but one, this will exceed the max URL length easily.

  1. Adjust backend API spec
  2. Update frontend accordingly
@Haarolean Haarolean added good first issue Up for grabs scope/frontend Related to frontend changes scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt labels Mar 15, 2024
@Haarolean Haarolean added this to the 1.1 milestone Mar 15, 2024
@kapybro kapybro bot added the status/triage Issues pending maintainers triage label Mar 15, 2024
@kapybro kapybro bot added area/messages status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 15, 2024
@Haarolean Haarolean mentioned this issue Mar 15, 2024
Merged
13 tasks
@Haarolean Haarolean moved this to One shots in Up for grabs Mar 16, 2024
@Haarolean
Copy link
Member Author

@germanosin wants to check if we are using generated requests rather than manually built ones?

@Vixtir Vixtir moved this from Todo to In Development in Release 1.1 Apr 25, 2024
@Haarolean Haarolean linked a pull request May 1, 2024 that will close this issue
FE: Messages: Explode partitions list in API #331
Merged
13 tasks
@Haarolean Haarolean removed the scope/backend Related to backend changes label May 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Up for grabs May 16, 2024
@github-project-automation github-project-automation bot moved this from In Development to Done in Release 1.1 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vixtir Vixtir

Labels
area/messages good first issue Up for grabs scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Release 1.1
Status: Done
Up for grabs
Status: Done
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

FE: Messages: Explode partitions list in API kafbat/kafka-ui
2 participants
@Haarolean @Vixtir