Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IPv6 to cluster-dns Usage Docs #11498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rivolity
Copy link

Proposed Changes

This update is based on the related PR/MR: rancher/rke2-docs#303.

While the RKE2/K3s clusterDNS variable (cluster-dns) supports both IPv4 and IPv6, the current documentation does not explicitly mention the option to use an IPv6 address for the cluster DNS. Users can configure the cluster DNS to use an IPv4, IPv6, or dual-stack address, as supported by the relevant script logic.

Types of Changes

Add explicit documentation for IPv6 support in the ClusterDNS usage section, highlighting its capability to handle IPv6 addresses.

Verification

The ClusterDNS can be configured to use IPv4/IPv6 addresses based on the CIDRs specified in config.yaml. By default, the IPv4 ClusterIP is 10.43.0.10. If an address from an IPv6 CIDR is specified, the ClusterDNS service will also receive an IPv6 address.

Testing

Ensure that IPv6 addresses are correctly assigned to the ClusterDNS service when an IPv6 CIDR is configured under IPs: when using kubectl describe svc rke2-coredns-rke2-coredns

Linked Issues

This update is based on the related PR/MR: rancher/rke2-docs#303.

User-Facing Change

NONE

Further Comments

@brandond
Copy link
Member

Thanks! Please --sign-off your commit for DCO.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.80%. Comparing base (68fbd1a) to head (07d43cb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11498      +/-   ##
==========================================
- Coverage   48.44%   43.80%   -4.65%     
==========================================
  Files         181      181              
  Lines       18809    18809              
==========================================
- Hits         9112     8239     -873     
- Misses       8348     9359    +1011     
+ Partials     1349     1211     -138     
Flag Coverage Δ
e2etests 35.73% <ø> (-7.68%) ⬇️
inttests 35.01% <ø> (-0.03%) ⬇️
unittests 14.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rivolity
Copy link
Author

rivolity commented Dec 24, 2024

sign-off commit DONE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants