Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Backport E2E GHA fixes #11229

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport of #11112 and #11226

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

* Fix vagrant/libvirt composite action for ubuntu-24.04

* Don't ignore changes to internal actions

* Fix unit tests for ubuntu 24.04, new lsof version

* Pin os version for unit and E2E workflows

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola requested a review from a team as a code owner November 5, 2024 00:06
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.88%. Comparing base (ae4df31) to head (abd8bda).
Report is 1 commits behind head on release-1.29.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #11229      +/-   ##
================================================
- Coverage         46.49%   41.88%   -4.61%     
================================================
  Files               178      178              
  Lines             18626    18618       -8     
================================================
- Hits               8660     7799     -861     
- Misses             8613     9617    +1004     
+ Partials           1353     1202     -151     
Flag Coverage Δ
e2etests 34.40% <ø> (-7.70%) ⬇️
inttests 34.70% <ø> (-0.03%) ⬇️
unittests 13.02% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 0089811 into k3s-io:release-1.29 Nov 5, 2024
30 checks passed
@dereknola dereknola deleted the vagrant_pin_1.29 branch November 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants